GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-43316: gzip: CLI uses non-zero return code on error. (GH-24647) by miss-islington · Pull Request #24648 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 25, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Exit code is now 1 instead of 0. A message is printed to stderr instead of stdout. This is
the proper behaviour for a tool that can be used in scripts.
(cherry picked from commit cc3df63)

Co-authored-by: Ruben Vorderman [email protected]

https://bugs.python.org/issue43316

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhpvorderman @miss-islington
bpo-43316: gzip: CLI uses non-zero return code on error. (pythonGH-24647
89024f3 
)

Exit code is now 1 instead of 0. A message is printed to stderr instead of stdout. This is
the proper behaviour for a tool that can be used in scripts.
(cherry picked from commit cc3df63)

Co-authored-by: Ruben Vorderman <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 25, 2021
@bedevere-bot bedevere-bot mentioned this pull request Feb 25, 2021
bpo-43316: gzip: CLI uses non-zero return code on error. #24647
Merged
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Feb 25, 2021
@miss-islington

miss-islington commented Feb 25, 2021

Copy link
Copy Markdown
Contributor Author

@rhpvorderman and @methane: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Feb 25, 2021
methane
methane approved these changes Feb 25, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 25, 2021
@miss-islington

miss-islington commented Feb 25, 2021

Copy link
Copy Markdown
Contributor Author

@rhpvorderman and @methane: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane
methane merged commit adea9b8 into python:3.9 Feb 26, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 26, 2021
@miss-islington
miss-islington deleted the backport-cc3df63-3.9 branch February 26, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @methane @the-knights-who-say-ni @bedevere-bot @rhpvorderman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.