GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43350: Don't reset active statements twice in _pysqlite_query_execute() by erlend-aasland · Pull Request #24681 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Mar 1, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue43350

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-43350: Don't reset active statements twice
2bc54e2
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner March 1, 2021 09:54
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 1, 2021
@bedevere-bot bedevere-bot added the awaiting review label Mar 1, 2021
@erlend-aasland

erlend-aasland commented Mar 1, 2021

Copy link
Copy Markdown
Contributor Author

CI seems stuck. Re-opening to trigger it again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Mar 1, 2021
@erlend-aasland erlend-aasland reopened this Mar 1, 2021
@github-actions

github-actions Bot commented Apr 1, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 1, 2021
@erlend-aasland erlend-aasland mentioned this pull request May 10, 2021
[minor code fix] Remove redundant reset() #26015
Closed
@gstein

gstein commented May 10, 2021

Copy link
Copy Markdown
Contributor

I would suggest this be closed, in favor of #26015, which adds a (void) to the remaining reset() invocation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added the skip news label May 24, 2021
Erlend E. Aasland added 2 commits June 5, 2021 21:07
Erlend E. Aasland
Merge branch 'main' into sqlite-duplicate-reset
58384b5
Erlend E. Aasland
Merge branch 'main' into sqlite-duplicate-reset
aab95c2
@erlend-aasland

erlend-aasland commented Aug 19, 2021

Copy link
Copy Markdown
Contributor Author

Closing this in favour of #27844.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Aug 19, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-duplicate-reset branch August 19, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @gstein @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.