GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777) by miss-islington · Pull Request #24830 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 12, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Check to make sure stdout and stderr are not empty before selecting an item from them in Windows subprocess._communicate.

Co-authored-by: Gregory P. Smith [email protected]
(cherry picked from commit b4fc44b)

Co-authored-by: Chris Griffith [email protected]

https://bugs.python.org/issue43423

Automerge-Triggered-By: GH:gpshead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cdgriffith @miss-islington
bpo-43423 Fix IndexError in subprocess _communicate function (pythonG…
c34d45c 
…H-24777)

Check to make sure stdout and stderr are not empty before selecting an item from them in Windows subprocess._communicate.

Co-authored-by: Gregory P. Smith <[email protected]>
(cherry picked from commit b4fc44b)

Co-authored-by: Chris Griffith <[email protected]>
@miss-islington
miss-islington requested a review from gpshead as a code owner March 12, 2021 01:32
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 12, 2021
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Mar 12, 2021
@bedevere-bot bedevere-bot mentioned this pull request Mar 12, 2021
bpo-43423 Fix IndexError in subprocess _communicate function #24777
Merged
@miss-islington

miss-islington commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

@cdgriffith and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Mar 12, 2021
@miss-islington

miss-islington commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

@cdgriffith and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

@cdgriffith and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead
gpshead approved these changes Mar 12, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 12, 2021
@gpshead gpshead added the 🤖 automerge label Mar 12, 2021
@miss-islington

miss-islington commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

@cdgriffith and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 1a5001c into python:3.8 Mar 12, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 12, 2021
@miss-islington
miss-islington deleted the backport-b4fc44b-3.8 branch March 12, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot @cdgriffith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.