GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43244: GitHub Action builds Python in debug mode on Windows by vstinner · Pull Request #24914 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 18, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The debug mode catchs more bugs but is slower.

https://bugs.python.org/issue43244

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner vstinner added the skip news label Mar 18, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 18, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Mar 18, 2021
@vstinner

vstinner commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

cc @zooba @zware @pablogsal

I didn't check yet if this change makes the CI way slower or not.

I wrote this PR since the Windows x64 job of GitHub Actions didn't catch the build error about Py_DebugFlag in test_peg_generator in my previous PR:
#24912 (comment)

Hopefully, we have at least one Windows buildbot running in release mode: https://buildbot.python.org/all/#/builders/405

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
bpo-43244: GitHub Action builds Python in debug mode on Windows
57d0a87
The debug mode catchs more bugs but is slower.
@vstinner

vstinner commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

Oh, test_peg_generator failed. I rebased my PR on top of my commit 57d0a87 fix.

test_locale also fails, I don't know why and I don't see why it only fails in debug mode:

ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_locale.py", line 567, in test_getsetlocale_issue1813
    locale.setlocale(locale.LC_CTYPE, loc)
  File "D:\a\cpython\cpython\lib\locale.py", line 610, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

The job still fails with:

ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_locale.py", line 567, in test_getsetlocale_issue1813
    locale.setlocale(locale.LC_CTYPE, loc)
  File "D:\a\cpython\cpython\lib\locale.py", line 610, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

With test_locale re-run in verbose mode, "the total tests duration is 19 min 41 sec.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

Oh, test_locale failure seems to be known since 2019: https://bugs.python.org/issue37945

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

Without this PR (Python built in release mode), tests take 12 min 19 sec on Windows x64. It should be compared with 19 min 41 sec with this PR. So this PR adds 7 minutes to the CI, it's quite signifiant (1.6x slower).

I'm not sure that I would like to make the CI slower on all PRs just because once per year there is a bug not catched by the pre-commit PR. I close the PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner closed this Mar 18, 2021
@vstinner
vstinner deleted the gha_win_debug branch March 18, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.