GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-43517: Fix false positive in detection of circular imports (GH-24895) by pitrou · Pull Request #24948 · python/cpython

Conversation

@pitrou

@pitrou pitrou commented Mar 20, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 2fd16ef)

Co-authored-by: Antoine Pitrou [email protected]

https://bugs.python.org/issue43517

Automerge-Triggered-By: GH:pitrou

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pitrou
[3.9] bpo-43517: Fix false positive in detection of circular imports (p…
c42d977 
…ythonGH-24895).

(cherry picked from commit 2fd16ef)

Co-authored-by: Antoine Pitrou <[email protected]>
@pitrou
pitrou requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners March 20, 2021 19:17
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 20, 2021
@bedevere-bot bedevere-bot mentioned this pull request Mar 20, 2021
bpo-43517: Fix false positive in detection of circular imports #24895
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting core review labels Mar 20, 2021
@pitrou pitrou added 🤖 automerge awaiting merge and removed awaiting core review labels Mar 20, 2021
@miss-islington

miss-islington commented Mar 20, 2021

Copy link
Copy Markdown
Contributor

@pitrou: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit ac17ed6 into python:3.9 Mar 20, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 20, 2021
@pitrou
pitrou deleted the backport-2fd16ef-3.9 branch March 20, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pitrou @miss-islington @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.