GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c. by shihai1991 · Pull Request #25115 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Mar 31, 2021 •
edited by vstinner
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue41111

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Move the Py_LIMITED_API macro of xxlimited module from setup.py to xx…
4cecd78 
…limited.c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 31, 2021
@bedevere-bot bedevere-bot added the awaiting review label Mar 31, 2021
@shihai1991 shihai1991 added the skip news label Mar 31, 2021
@shihai1991 shihai1991 changed the title bpo-4111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c. bpo-41111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c. Mar 31, 2021
@shihai1991 shihai1991 closed this Mar 31, 2021
@shihai1991 shihai1991 reopened this Mar 31, 2021
@shihai1991
shihai1991 requested a review from vstinner April 1, 2021 01:00
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_41111
7c8106d
@shihai1991
shihai1991 requested a review from a team as a code owner April 1, 2021 15:36
vstinner
vstinner reviewed Apr 2, 2021
View reviewed changes
Comment thread setup.py
define_macros=[('WITH_Py_LIMITED_API', 1)]))
else:
# Debug mode: Build xxlimited with the full API
# (which is compatible with the limited one)

@vstinner vstinner Apr 1, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, I'm disappointed that CPython doesn't even support its own stable ABI in debug mode. So I created https://bugs.python.org/issue43688 to also support the limited C API in debug mode.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/xxlimited.c Outdated

/* xxlimited with the limited API. */
#ifdef WITH_Py_LIMITED_API
# define Py_LIMITED_API 0x03100000

@vstinner vstinner Apr 1, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x03100000 is wrong: it must be 0x030a0000 (the bug exists in the current code). I fixed the issue in my PR #25131.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented Apr 2, 2021

Copy link
Copy Markdown
Member

Oops. I forgot to publish my review. In the meanwhile, I fixed both issues in https://bugs.python.org/issue43688.

I created a new PR: PR #25151.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 2, 2021

Copy link
Copy Markdown
Member

I merged PR #25151 instead, I marked you as a co-author of my change ;-)
shihai1991 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Apr 2, 2021
@vstinner vstinner mentioned this pull request Nov 3, 2022
[C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283
Closed
@vstinner vstinner mentioned this pull request May 22, 2023
[C API] Support the limited C API in debug mode (Py_INCREF and Py_DECREF) #87854
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.