GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43725: Add CI step to check changes in the exported ABI by pablogsal · Pull Request #25188 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Apr 4, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue43725

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 4, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 4, 2021
@pablogsal
pablogsal force-pushed the abicheck branch from aa6805c to 16b664e Compare April 4, 2021 20:30
@pablogsal pablogsal changed the title Add CI step to check changes in the exported ABI bpo-43725: Add CI step to check changes in the exported ABI Apr 4, 2021
@pablogsal
pablogsal force-pushed the abicheck branch 6 times, most recently from 311b675 to 953b0f1 Compare April 4, 2021 20:55
@pablogsal

pablogsal commented Apr 4, 2021

Copy link
Copy Markdown
Member Author

Unfortunately seems that doing this check with two different compiler versions produce some different DWARF and the tool identifies the differences as errors :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal closed this Apr 4, 2021
gpshead
gpshead approved these changes Apr 4, 2021
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, lets try it out! I suppose this shows up as a non-blocking check by default? Release branch owners can presumably decide if this is reliable enough to make it blocking.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal pablogsal reopened this Apr 4, 2021
@pablogsal

pablogsal commented Apr 4, 2021

Copy link
Copy Markdown
Member Author

I will try to investigate how to overcome this:

Unfortunately seems that doing this check with two different compiler versions produce some different DWARF and the tool identifies the differences as errors :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Add CI step to check changes in the exported ABI
045817f
@pablogsal
pablogsal force-pushed the abicheck branch from 953b0f1 to 045817f Compare April 4, 2021 21:08
@pablogsal

pablogsal commented Apr 4, 2021

Copy link
Copy Markdown
Member Author

@gpshead Check my message in https://bugs.python.org/msg390213 with the analysis of this solution.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Apr 4, 2021
View reviewed changes
Comment thread .github/workflows/build.yml

check_abi:
name: 'Check if the ABI has changed'
runs-on: ubuntu-latest

@erlend-aasland erlend-aasland Apr 4, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd pin the runner, to ensure that the job runs with at least the same major GCC version every time. Ref. bpo-43382.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal pablogsal closed this Apr 6, 2021
@pablogsal
pablogsal deleted the abicheck branch May 19, 2021 18:57
@gpshead gpshead mentioned this pull request May 23, 2023
Create a release branch ABI stability regression test #87891
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @gpshead @erlend-aasland @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.