GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43770: _PyTypes_Init() inits _PyAnextAwaitable_Type by vstinner · Pull Request #25266 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 7, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Rename PyAnextAwaitable_Type to _PyAnextAwaitable_Type.
  • Expose the type in the internal C API.

https://bugs.python.org/issue43770

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-43770: _PyTypes_Init() inits _PyAnextAwaitable_Type
bb7dcbf 
* Rename PyAnextAwaitable_Type to _PyAnextAwaitable_Type.
* Expose the type in the internal C API.
@vstinner vstinner added the skip news label Apr 7, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 7, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 7, 2021
@vstinner vstinner mentioned this pull request Apr 7, 2021
bpo-31861: Provide aiter and anext builtins #23847
Merged
vstinner
vstinner commented Apr 7, 2021
View reviewed changes
Comment thread Include/iterobject.h
PyAPI_DATA(PyTypeObject) PyCallIter_Type;
#ifdef Py_BUILD_CORE
extern PyTypeObject _PyAnextAwaitable_Type;
#endif

@vstinner vstinner Apr 7, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved inside _PyTypes_Init(). I tried to mimick other header files which defines all types.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum

gvanrossum commented Apr 7, 2021

Copy link
Copy Markdown
Member

+1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit b98eba5 into python:master Apr 8, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 8, 2021
@vstinner
vstinner deleted the anext_await branch April 8, 2021 07:58
@vstinner

vstinner commented Apr 8, 2021

Copy link
Copy Markdown
Member Author

Merged. Thanks for the review @gvanrossum.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.