GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42998: add 'user' parameter to pathlib.Path.home() by barneygale · Pull Request #25271 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Apr 8, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Also slightly re-arrange the internals such that expanduser() calls home().
This is to aid with the creation of an AbstractPath class in bpo-24132,
where cwd() and home() will be abstract methods, but not absolute()
or expanduser().

https://bugs.python.org/issue42998

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 8, 2021
@bedevere-bot bedevere-bot added the awaiting review label Apr 8, 2021
@barneygale

barneygale commented Apr 8, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Needs tests and NEWS.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale changed the title WIP: bpo-42998: add 'username' parameter to pathlib.Path.home() WIP: bpo-42998: add 'user' parameter to pathlib.Path.home() Apr 8, 2021
@barneygale
barneygale marked this pull request as ready for review April 8, 2021 20:57
@barneygale barneygale changed the title WIP: bpo-42998: add 'user' parameter to pathlib.Path.home() bpo-42998: add 'user' parameter to pathlib.Path.home() Apr 8, 2021
@barneygale

barneygale commented Apr 13, 2021

Copy link
Copy Markdown
Contributor Author

Pretty sure the test failure is unrelated to my changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
barneygale added 3 commits April 24, 2021 22:31
@barneygale
bpo-42998: add 'username' parameter to pathlib.Path.home()
1244a6c 
Slightly re-arrange the internals such that `expanduser()` calls `home()`.
This is to aid with the creation of an `AbstractPath` class in bpo-24132,
where `cwd()` and `home()` will be abstract methods, but not `absolute()`
or `expanduser()`.
@barneygale
Add NEWS
603f12a
@barneygale
Add tests
43e7456
@barneygale
barneygale force-pushed the bpo-42998-pathlib-home-username-parameter branch from 42a44e6 to 43e7456 Compare April 24, 2021 21:32
@barneygale

barneygale commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

Closing this PR, as it looks like resolving other users' home directories isn't something we can rely on!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale closed this Apr 28, 2021
@projetmbc projetmbc mannequin mentioned this pull request Jun 21, 2022
Direct sub-classing of pathlib.Path #68320
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@barneygale @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.