GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39899: ntpath.expanduser(): don't check the basename of the directory matches the username if we're requesting the current user's home directory by barneygale · Pull Request #25277 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Apr 8, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Eryk Sun spotted that the implementation in #18841 shouldn't perform the basename check if we're querying for the current user's home directory via ~user.

https://bugs.python.org/issue39899

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 8, 2021
@bedevere-bot bedevere-bot added the awaiting review label Apr 8, 2021
@barneygale barneygale changed the title ntpath.expanduser(): don't check the basename of the directory matches the username if we're requesting the current user's home directory bpo-39899: ntpath.expanduser(): don't check the basename of the directory matches the username if we're requesting the current user's home directory Apr 8, 2021
@barneygale
ntpath.expanduser(): don't check the basename of the directory matche…
9bc1674 
…s the username if we're requesting the current user's home directory
@barneygale

barneygale commented Apr 8, 2021

Copy link
Copy Markdown
Contributor Author

@zooba flagging for review, if you have a mo? This is a follow-up to #18841 that fixes a mistake. Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba added the skip news label Apr 9, 2021
@zooba
zooba merged commit ba1db57 into python:master Apr 9, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Apr 9, 2021
@barneygale barneygale mannequin mentioned this pull request Apr 10, 2022
pathlib.Path.expanduser() does not call os.path.expanduser() #84080
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@barneygale @zooba @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.