GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] Revert "[3.9] bpo-43725: Add ignore file for the abidump check" by pablogsal · Pull Request #25394 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Apr 13, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reverts #25323

https://bugs.python.org/issue43725

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
Revert "Add ignore file for the abidump check (GH-25323)"
60b70fd 
This reverts commit b3fec75.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 13, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 13, 2021
@pablogsal pablogsal changed the title Revert "[3.9] bpo-43725: Add ignore file for the abidump check" [3.9] Revert "[3.9] bpo-43725: Add ignore file for the abidump check" Apr 13, 2021
@pablogsal pablogsal added the skip news label Apr 13, 2021
@vstinner

vstinner commented Apr 13, 2021

Copy link
Copy Markdown
Member

_Py_M__importlib_bootstrap_external should be ignored explictly, no? See: https://bugs.python.org/issue43725#msg390660
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Apr 13, 2021

Copy link
Copy Markdown
Member Author

_Py_M__importlib_bootstrap_external should be ignored explictly, no? See: https://bugs.python.org/issue43725#msg390660

That is only for 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Apr 13, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we need to manually ignore symbols tomorrow, we can add again the ignorefile.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 13, 2021
@pablogsal
pablogsal merged commit 4da5ca5 into 3.9 Apr 13, 2021
@pablogsal
pablogsal deleted the revert-25323-abicheck-ignore3.9 branch April 13, 2021 23:26
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 13, 2021
@gpshead gpshead mentioned this pull request May 23, 2023
Create a release branch ABI stability regression test #87891
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.