GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43844: Fix PendingDeprecationWarning in test_lib2to3 by vstinner · Pull Request #25407 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 14, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue43844

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-43844: Fix PendingDeprecationWarning in test_lib2to3
c198173
@vstinner vstinner added the skip news label Apr 14, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 14, 2021
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Apr 14, 2021
@vstinner

vstinner commented Apr 14, 2021

Copy link
Copy Markdown
Member Author

cc @tirkarthi
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner commented Apr 15, 2021
View reviewed changes
Comment thread Lib/lib2to3/tests/test_parser.py
env=sub_env)
""" % (grammar_sub_copy,)
msg = ("lib2to3 package is deprecated and may not be able "
"to parse Python 3.10+")

@vstinner vstinner Apr 15, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PR #25406, I added distutils._DEPRECATION_MESSAGE constant to avoid copying the error message. Is it worth it?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit 471870f into python:master Apr 16, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 16, 2021
@vstinner
vstinner deleted the lib2to3_warn branch April 16, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.