GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40443: Remove unused imports by vstinner · Pull Request #25429 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 16, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • pyclbr no longer uses copy
  • typing no longer uses ast

Issue discovered by pyflakes.

https://bugs.python.org/issue40443

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-40443: Remove unused imports
4bf63f9 
* pyclbr no longer uses copy
* typing no longer uses ast

Issue discovered by pyflakes.
@vstinner
vstinner requested review from gvanrossum and ilevkivskyi as code owners April 16, 2021 00:04
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 16, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 16, 2021
@vstinner

vstinner commented Apr 16, 2021

Copy link
Copy Markdown
Member Author

@isidentical: You added import ast in commit 044a104. Was it a mistake? Can it be removed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@isidentical

isidentical commented Apr 16, 2021

Copy link
Copy Markdown
Member

I think so, it is probably a leftover from another commit in that PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
isidentical
isidentical approved these changes Apr 16, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 16, 2021
@vstinner
vstinner merged commit a6a5c91 into python:master Apr 16, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 16, 2021
@vstinner
vstinner deleted the remove_unused_imports branch April 16, 2021 09:26
@vstinner vstinner mentioned this pull request Jun 27, 2022
Remove unused imports in the stdlib (April 2020 edition) #84623
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical isidentical approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @isidentical @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.