GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43795: PEP-652: Clean up the stable ABI/limited API by encukou · Pull Request #25482 · python/cpython

Conversation

@encukou

@encukou encukou commented Apr 20, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • _Py_EncodeLocaleRaw, which is private by name, undocumented,
    and wasn't exported in python3.dll, is moved to a private header.
  • _Py_HashSecret_Initialized, again private by name, undocumented,
    and not exported in python3.dll, is excluded with Py_LIMITED_API.
  • PyMarshal_* and PyMember_*One functions, declared in private headers and
    not exported in python3.dll, are removed from Doc/data/stable_abi.dat.
  • PyMem_Calloc which was exported in python3dll.c, is moved to public
    headers where it joins its other PyMem_* friends.

Only the last change is documented in the blurb; others are not user-visible.
(Nothing uses Doc/data/stable_abi.dat yet.)

https://bugs.python.org/issue43795

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
encukou added 5 commits April 20, 2021 14:40
@encukou
Move _Py_EncodeLocaleRaw to the private header
db837c1
This symbol is not part of the limited API, and was even missing
in Python's stable ABI DLL.
@encukou
Don't define _Py_HashSecret_Initialized in limited API
2f05fde
The underscore means it's not public API.
It was also not exported in the Windows stable ABI library.
@encukou
Remove PyMarshal_* and PyMember_{Get,Set}One functions from the limit…
1d11e55
…ed API

These functions are not declared with Py_LIMITED_API.
Except for functions that take FILE*, they remain in the stable ABI.
@encukou
Include PyMem_Calloc in the limited API
75094f4
@encukou
Add blurb
2ec383f
@encukou
encukou requested a review from tiran as a code owner April 20, 2021 13:21
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 20, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 20, 2021
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 20, 2021
@bedevere-bot

bedevere-bot commented Apr 20, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 2ec383f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 20, 2021
@encukou encukou mentioned this pull request Apr 20, 2021
Create a definitive list of what's in the stable ABI encukou/abi3#3
Closed
@encukou
encukou merged commit 9d6a2d0 into python:master Apr 23, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 23, 2021
@encukou
encukou deleted the pep652-cleanup branch April 23, 2021 12:18
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.