GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43795: PEP-652: Simplify headers for easier static analysis by encukou · Pull Request #25483 · python/cpython

Conversation

@encukou

@encukou encukou commented Apr 20, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As part of the PEP-652 implementation, I'll tighten the CI check
for functions/data defined with Py_LIMITED_API.

Discussion in https://discuss.python.org/t/pep-652-maintaining-the-stable-abi/6986
suggests that parsing C headers is OK (though personally I'd rather generate it...),
but writing a full C parser is a monumental task and adding an existing one as a
dependency brings too many vendoring/bootstraping issues.

So, for the check I'll use a "simple" regex on preprocessor output, and adapt
the few trivial places where the regex won't work.

  • Keep declarations in the limited API to one item per line
  • Make it possible to override _Py_NO_RETURN, so the annotation can be
    removed from preprocessor output.

https://bugs.python.org/issue43795

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
encukou added 2 commits April 20, 2021 14:21
@encukou
boolobject.h: One declaration per line
43e454a
This makes static analysis easier.

From discussion at https://discuss.python.org/t/pep-652-maintaining-the-stable-abi/6986/13
it is clear that:
- parsing C to get information is okay (though I personally prefer to *generate* it)
- writing a full C parser is a monumental task (and adding an existing one as a dependency
  is not feasible)

I think it's reasonable to simplify our declarations in order to make header checks
easier, rather than write a parser that can handle all C.
@encukou
Include/pyport.h: Don't define _Py_NO_RETURN if already defined
e415076
This makes static analysis of the headers easier.
@encukou encukou added the skip news label Apr 20, 2021
@encukou
encukou requested a review from vstinner April 20, 2021 14:30
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 20, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 20, 2021
vstinner
vstinner approved these changes Apr 20, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 20, 2021
@encukou
encukou merged commit e7cc64e into python:master Apr 23, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 23, 2021
@encukou
encukou deleted the pep652-simplify-headers branch April 23, 2021 12:14
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.