GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43957: [Enum] deprecate ``TypeError`` from containment checks by ethanfurman · Pull Request #25670 · python/cpython

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Apr 27, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In 3.12 True or False will be returned for all containment checks,
with True being returned if the value is either a member of that enum
or one of its members' value.

https://bugs.python.org/issue42957

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ethanfurman
[Enum] Deprecate TypeError from containment checks.
ff295ab 
In 3.12 ``True`` or ``False`` will be returned for all containment checks,
with ``True`` being returned if the value is either a member of that enum
or one of its members' value.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 27, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 27, 2021
@zooba

zooba commented Apr 27, 2021

Copy link
Copy Markdown
Member

I'm not sure what the actual bug number for this is, but it isn't 42957.

(Note that even if you rename the issue, if there's only one commit then the "merge" button will default to that commit message rather than taking the bug number from the title.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ethanfurman ethanfurman changed the title bpo-42957: [Enum] deprecate TypeError from containment checks bpo-43957: [Enum] deprecate TypeError from containment checks Apr 27, 2021
@ethanfurman

ethanfurman commented Apr 27, 2021

Copy link
Copy Markdown
Member Author

@zooba Thanks, title fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ethanfurman
ethanfurman merged commit 6bd9288 into python:master Apr 27, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 27, 2021
@ethanfurman
ethanfurman deleted the enum-contains branch October 21, 2021 18:19
@ethanfurman ethanfurman mentioned this pull request Apr 10, 2022
[Enum] update __contains__ to return True for valid values #88123
Closed
@tirkarthi tirkarthi mentioned this pull request May 25, 2022
DeprecationWarning in test_enum #93216
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 6, 2026
Development suitenumerique/messages#728
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ethanfurman @zooba @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.