GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||
GeezerVison is showing github.com — bpo-28254: _posixsubprocess uses PyGC_Enable/PyGC_Disable by vstinner · Pull Request #25693 · python/cpython Conversation
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
👀 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks. I fixed test_subprocess. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Actually, I think much of this could already have been saved before by using the ID-string API. But still, this is just so much better. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I don't think that using cached interned strings is really relevant here, spawning a subprocess takes a few milliseconds, we are far from nanoseconds avoided thanks to the cache. Anyway, it's now gone ;-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
yay, thanks for the cleanup!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| preexec_fn=lambda: None) | ||
| finally: | ||
| gc.disable = orig_gc_disable | ||
| gc.isenabled = orig_gc_isenabled |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
saving and restoring these two with the try: finally: seems no longer necessary now that they're not being monkeypatched out to cause errors. (harmless, but anyone reading this will wonder why...)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Oh, you're right: I created #25709
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.