GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43970: Optimize Path.cwd() in pathlib by kfollstad · Pull Request #25699 · python/cpython

Conversation

@kfollstad

@kfollstad kfollstad commented Apr 28, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Avoid instantiating a class unnecessarily.

https://bugs.python.org/issue43970

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kfollstad
bpo-43970: Optimize Path.cwd() in pathlib
6431df0
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 28, 2021
@bedevere-bot bedevere-bot added the awaiting review label Apr 28, 2021
@ericvsmith ericvsmith added the skip news label Apr 28, 2021
@domdfcoding

domdfcoding commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

cc @barneygale as I've seen you've been working on improving pathlib
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale

barneygale commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

LGTM! This wasn't previously possible because _accessor was set at initialization time, but that changed in 2219187.

+1 from me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericvsmith
ericvsmith merged commit 4a85718 into python:master Apr 28, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Apr 28, 2021
@barneygale

barneygale commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

@kfollstad thanks very much!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kfollstad kfollstad mentioned this pull request Apr 29, 2021
bpo-43012: remove pathlib._Accessor #25701
Merged
@kfollstad
kfollstad deleted the PathlibCwdFix branch April 29, 2021 16:45
@coderabbitai coderabbitai Bot mentioned this pull request Sep 23, 2026
feat(workspace): guard ordinary output from managed state (S3 1/5) Villeneuve-Ventures/graphify#156
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@kfollstad @domdfcoding @barneygale @ericvsmith @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.