GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43933: Show frame.f_lineno as None, rather than -1, if there is no line number. by markshannon · Pull Request #25717 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Apr 29, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As specified by PEP 626.
This should not be observable unless frame.f_trace_opcodes is set, or some other oddity.

https://bugs.python.org/issue43933

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 29, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 29, 2021
markshannon added 2 commits April 29, 2021 14:06
@markshannon
Show frame.f_lineno as None, rather than -1, if there is no line number.
fd6c7d5
@markshannon
Add NEWS
9bd0186
@markshannon
markshannon force-pushed the present-none-if-missing-lineno branch from 046b8ae to 9bd0186 Compare April 29, 2021 13:07
@encukou

encukou commented Apr 29, 2021

Copy link
Copy Markdown
Member

The "Check if generated files are up to date" test is failing because of unfortunate timing when merging other PRs (GH-25315, GH-25687).
It's OK to ignore it. Sorry for the inconvenience.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon closed this Apr 29, 2021
@markshannon markshannon reopened this Apr 29, 2021
@markshannon
Don't recompute line number.
2752916
@markshannon
markshannon merged commit 088a15c into python:master Apr 29, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 29, 2021
@markshannon
markshannon deleted the present-none-if-missing-lineno branch May 4, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @encukou @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.