GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. (GH-25595) by miss-islington · Pull Request #25728 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 29, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • issue43882 - urllib.parse should sanitize urls containing ASCII newline and tabs.

Co-authored-by: Gregory P. Smith [email protected]
Co-authored-by: Serhiy Storchaka [email protected]
(cherry picked from commit 76cd81d)

Co-authored-by: Senthil Kumaran [email protected]

https://bugs.python.org/issue43882

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@orsenthil @miss-islington
bpo-43882 - urllib.parse should sanitize urls containing ASCII newlin…
fa537f3 
…e and tabs. (pythonGH-25595)

* issue43882 - urllib.parse should sanitize urls containing ASCII newline and tabs.

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit 76cd81d)

Co-authored-by: Senthil Kumaran <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Apr 29, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 29, 2021
@miss-islington

miss-islington commented Apr 29, 2021

Copy link
Copy Markdown
Contributor Author

@orsenthil: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Apr 29, 2021
bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. #25595
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error type-security A security issue labels Apr 29, 2021
orsenthil
orsenthil approved these changes Apr 29, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 29, 2021
@orsenthil
orsenthil self-requested a review April 29, 2021 17:18
orsenthil added 2 commits April 29, 2021 10:27
@orsenthil
Update version to 3.6.14
c5c33b4
@orsenthil
Fix 3.6 tests.
630c3b7
@orsenthil

orsenthil commented May 5, 2021

Copy link
Copy Markdown
Member

Closing this in favor of #25924 (Same code, the backport was from 3.8 merge).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orsenthil orsenthil closed this May 5, 2021
@miss-islington
miss-islington deleted the backport-76cd81d-3.6 branch May 5, 2021 23:21
@orsenthil orsenthil mentioned this pull request Aug 25, 2022
[security] CVE-2022-0391: urllib.parse should sanitize urls containing ASCII newline and tabs. #88048
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil Awaiting requested review from orsenthil

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge type-bug An unexpected behavior, bug, or error type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @orsenthil @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.