GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43995: Fix test_grammar by erlend-aasland · Pull Request #25764 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 30, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue43995

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
Fix ref leak in test_grammar
f9c3420
@bedevere-bot bedevere-bot added the awaiting review label Apr 30, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 30, 2021
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 30, 2021
@erlend-aasland

erlend-aasland commented Apr 30, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@pablogsal, does this belong in issue 43901?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title Fix ref leak in test_grammar Fix test_grammar Apr 30, 2021
@erlend-aasland erlend-aasland changed the title Fix test_grammar bpo-43995: Fix test_grammar Apr 30, 2021
@erlend-aasland

erlend-aasland commented Apr 30, 2021

Copy link
Copy Markdown
Contributor Author

FYI, Azure Pipelines failure is unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Apr 30, 2021

Copy link
Copy Markdown
Member

@pablogsal, does this belong in issue 43901?

Yeah, but having an issue for this is also ok. Can you leave a comment in 43901 regarding this fix?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Apr 30, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 30, 2021
@pablogsal pablogsal added the skip news label Apr 30, 2021
@pablogsal
pablogsal merged commit e467ec4 into python:master Apr 30, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 30, 2021
@pablogsal

pablogsal commented Apr 30, 2021

Copy link
Copy Markdown
Member

Thanks a lot @erlend-aasland !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the ref-leak-grammar branch April 30, 2021 23:25
@erlend-aasland

erlend-aasland commented Apr 30, 2021

Copy link
Copy Markdown
Contributor Author

Thank you, @pablogsal! I'll add a short note about this at 43901 :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.