GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. by miss-islington · Pull Request #25923 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 5, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Co-authored-by: Gregory P. Smith [email protected]
Co-authored-by: Serhiy Storchaka [email protected]
(cherry picked from commit 76cd81d)
Co-authored-by: Senthil Kumaran [email protected]
Co-authored-by: Senthil Kumaran [email protected]
(cherry picked from commit 515a7bc)

Co-authored-by: Miss Islington (bot) [email protected]

https://bugs.python.org/issue43882

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@miss-islington
[3.8] bpo-43882 - urllib.parse should sanitize urls containing ASCII …
f46e2e4
…newline and tabs. (pythonGH-25595) (pythonGH-25726)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit 76cd81d)
Co-authored-by: Senthil Kumaran <[email protected]>
Co-authored-by: Senthil Kumaran <[email protected]>
(cherry picked from commit 515a7bc)

Co-authored-by: Miss Islington (bot) <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label May 5, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 5, 2021
@miss-islington

miss-islington commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

@orsenthil: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot mentioned this pull request May 5, 2021
[3.8] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. (GH-25595) #25726
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error type-security A security issue labels May 5, 2021
@miss-islington

miss-islington commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

@orsenthil: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@orsenthil orsenthil changed the title [3.7] [3.8] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. (GH-25595) (GH-25726) [3.7] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. May 5, 2021
@orsenthil
Update versionchanged to 3.7.11
eb3fdd5
@orsenthil orsenthil mentioned this pull request May 5, 2021
[3.7] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. (GH-25595) #25727
Closed
@orsenthil orsenthil assigned ned-deily May 5, 2021
@ned-deily
ned-deily merged commit f4dac7e into python:3.7 May 6, 2021
@bedevere-bot bedevere-bot removed the awaiting review label May 6, 2021
@miss-islington
miss-islington deleted the backport-515a7bc-3.7 branch May 6, 2021 16:52
@bedevere-bot

bedevere-bot commented May 6, 2021

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.7 has failed when building commit f4dac7e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/430/builds/4) and take a look at the build logs.
  4. Check if the failure is related to this commit (f4dac7e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/430/builds/4

Failed tests:

  • test_socket

Failed subtests:

  • testSendFrame - test.test_socket.CANTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

403 tests OK.

1 test failed:
test_socket

12 tests skipped:
test_asdl_parser test_clinic test_devpoll test_gdb test_ioctl
test_kqueue test_msilib test_startfile test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_socket

Total duration: 26 min 12 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.7.ware-gentoo-x86.installed/build/target/lib/python3.7/test/test_socket.py", line 1866, in testSendFrame
    self.assertEqual(addr[0], self.interface)
AssertionError: 'v' != 'vcan0'
- v
+ vcan0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented May 6, 2021

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.7 has failed when building commit f4dac7e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/351/builds/4) and take a look at the build logs.
  4. Check if the failure is related to this commit (f4dac7e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/351/builds/4

Failed tests:

  • test_socket

Failed subtests:

  • testSendFrame - test.test_socket.CANTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

406 tests OK.

10 slowest tests:

  • test_tokenize: 3 min 57 sec
  • test_concurrent_futures: 3 min 41 sec
  • test_multiprocessing_spawn: 3 min 19 sec
  • test_lib2to3: 3 min 18 sec
  • test_tools: 2 min 31 sec
  • test_multiprocessing_forkserver: 1 min 57 sec
  • test_asyncio: 1 min 31 sec
  • test_multiprocessing_fork: 1 min 26 sec
  • test_io: 1 min 18 sec
  • test_gdb: 1 min 12 sec

1 test failed:
test_socket

9 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_startfile
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_socket

Total duration: 28 min 33 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.7.ware-gentoo-x86.nondebug/build/Lib/test/test_socket.py", line 1866, in testSendFrame
    self.assertEqual(addr[0], self.interface)
AssertionError: 'v' != 'vcan0'
- v
+ vcan0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@orsenthil orsenthil mentioned this pull request Aug 25, 2022
[security] CVE-2022-0391: urllib.parse should sanitize urls containing ASCII newline and tabs. #88048
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ned-deily ned-deily

Labels

type-bug An unexpected behavior, bug, or error type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni @orsenthil
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.