GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-43795: Mark PyCodec_Unregister as a function, not data, in stable ABI (GH-25920) by miss-islington · Pull Request #25925 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 5, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit cf86996)

Co-authored-by: Petr Viktorin [email protected]

https://bugs.python.org/issue43795

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou @miss-islington
bpo-43795: Mark PyCodec_Unregister as a function, not data, in stable…
8c4f592 
… ABI (pythonGH-25920)

(cherry picked from commit cf86996)

Co-authored-by: Petr Viktorin <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner May 5, 2021 17:32
@bedevere-bot bedevere-bot added the awaiting review label May 5, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 5, 2021
@miss-islington

miss-islington commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2021
bpo-43795: Mark PyCodec_Unregister as a function, not data, in stable ABI #25920
Merged
@encukou

encukou commented May 5, 2021

Copy link
Copy Markdown
Member

@pablogsal, I hope this fix is fine in beta.
PyCodec_Unregister was added in 3.10.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes May 5, 2021
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM

Also, is in the last beta when the ABI freezes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 5, 2021
@miss-islington
miss-islington merged commit 8f3ef45 into python:3.10 May 5, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label May 5, 2021
@miss-islington
miss-islington deleted the backport-cf86996-3.10 branch May 5, 2021 18:15
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @encukou @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.