GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — Feature/replace list comp with generator by zkneupper · Pull Request #26046 · python/cpython Conversation
Contributor
Replace list comprehensions with generator expressions inside str.join()
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
Hi, and thank you for your interest in making CPython faster. Unfortunately, these changes are de-optimisations; list comprehensions are faster than generators. See Serhiy's review comment in #25798 (comment) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
This is making the code look worse for the _pad_whitespace. Thanks for the contribution (are these automated?) though please refrain from posting this kind of changes in the future for the different parts of the codebase. If you know a potential improvement, open an issue and send a PR for that issue only.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.