GeezerVison

We add these with:

PyModule_AddIntConstant(m, "_READLINE_VERSION", RL_READLINE_VERSION);

So maybe we don't need the hasattr check?

Also, we need to know this is libedit, and looking at the tests, we need:

is_editline = readline.__doc__ and "libedit" in readline.__doc__

So maybe we don't need the hasattr check?

I like the idea of using test_readline unchanged on Python implementations other than CPython. Tests cannot rely on private attributes in tests, not without @cpython_only or hasattr(). I added a comment to explain the rationale.

is_editline

Right, I also logged this flag, even if the other attributes are not available.

I chose to also expose rl_library_version as a private attribute to be able to log it in test_readline. It may help to debug subtle differences between two readline versions, and validate manually is_editline flag.

@berkerpeksag version showing "readline implementation: libedit|GNU readline" can be little nicer.

I changed that.

Why not uppercase like the other constants?

Oh, I didn't notice that the variable on the previous line is in lower case but exported as UPPER case. I converted my new constant to UPPER case and rename "rl" to READLINE, as done for the 2nd constant.

I don't like duplicating the horrible doc check, and adding a new incompatible check for the same thing.

I don't like duplicating the horrible doc check, and adding a new incompatible check for the same thing.

IMHO such enhancement would deserves its own PR ;-)