GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43216: Remove @asyncio.coroutine by illia-v · Pull Request #26369 · python/cpython

Conversation

@illia-v

@illia-v illia-v commented May 25, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@asyncio.coroutine was scheduled for removal in Python 3.10 originally.

https://bugs.python.org/issue43216

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@illia-v
illia-v requested review from 1st1, asvetlov and rhettinger as code owners May 25, 2021 20:41
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 25, 2021
@bedevere-bot bedevere-bot added the awaiting review label May 25, 2021
@illia-v
bpo-43216: Remove @asyncio.coroutine
4e037da
@illia-v
illia-v force-pushed the bpo-43216 branch from 0f7148c to 4e037da Compare May 25, 2021 20:58
graingert
graingert approved these changes May 25, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 25, 2021
vstinner
vstinner reviewed May 26, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @1st1 @asvetlov

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/asyncio/coroutines.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
illia-v added 2 commits May 26, 2021 19:55
@illia-v
Update the news entry
c1df1f0
@illia-v
Remove CoroWrapper
92e8d2e
@illia-v
illia-v requested a review from vstinner May 26, 2021 16:59
@illia-v
Remove unused imports
a62103a
vstinner
vstinner reviewed May 26, 2021
View reviewed changes
Comment thread Doc/library/asyncio-task.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
illia-v added 2 commits May 26, 2021 23:17
@illia-v
Revert removal of useful documentation
769201f
@illia-v
Remove a comment mentioning CoroWrapper
7ebb5b1
@illia-v
illia-v requested a review from vstinner May 26, 2021 20:27
vstinner
vstinner reviewed May 26, 2021
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@illia-v
Document removal of CoroWrapper
b36f792
@illia-v
illia-v requested a review from vstinner May 26, 2021 20:49
vstinner
vstinner approved these changes May 26, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would prefer that @1st1 or @asvetlov merged it.

I only quickly looked at test changes. I'm fine with removing legacy @asyncio.coroutine, async def is now standard and preferred.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
illia-v and graingert reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 26, 2021
@rhettinger
rhettinger removed their request for review May 31, 2021 19:43
@github-actions

github-actions Bot commented Jul 1, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 1, 2021
@graingert

graingert commented Jul 1, 2021

Copy link
Copy Markdown
Contributor

This isn't stale
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert

graingert commented Jul 1, 2021

Copy link
Copy Markdown
Contributor

@1st1 @asvetlov
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Jul 1, 2021
@vstinner vstinner reopened this Jul 1, 2021
@vstinner

vstinner commented Jul 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

multiprocessing tests hang on Address sanitizer. I cannot merge the PR because of it :-(

cc @pablogsal
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Jul 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

multiprocessing tests hang on Address sanitizer. I cannot merge the PR because of it :-(

That's weird. Maybe run them again? We can look into increasing timeout for that run or excluding those
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 requested a review from aeros July 1, 2021 02:20
@vstinner
vstinner merged commit a1092f6 into python:main Jul 1, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 1, 2021
@vstinner

vstinner commented Jul 1, 2021

Copy link
Copy Markdown
Member

Merged, thanks.

I decided to no longer wait for @1st1 or @asvetlov since they seem to be busy. The change looks reasonable.

If this change breaks too many asyncio project, we can consider to revert it, help projects to migrate, and reschedule the removal once enough projects migrated. I hope that in 2021, most projects are now written with "async def" and "await". The @coroutine syntax is a legacy of Python 3.4-3.5 era. I know that one of reasons why Instagram migrated from Python 2.7 to 3.6 is to get async def syntax!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert

graingert commented Jul 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@vstinner did this miss the deadline for py3.10 backport?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@illia-v

illia-v commented Jul 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Thanks @vstinner & @graingert!

@vstinner did this miss the deadline for py3.10 backport?

This removal was discussed shortly before the 3.10 feature freeze. Victor suggested to wait for Python 3.11 to remove the decorator.
graingert reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@illia-v
illia-v deleted the bpo-43216 branch July 1, 2021 13:43
@vstinner

vstinner commented Jul 1, 2021

Copy link
Copy Markdown
Member

This removal was discussed shortly before the 3.10 feature freeze. Victor suggested to wait for Python 3.11 to remove the decorator.

Exactly ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert graingert mentioned this pull request Jul 17, 2022
make asyncio.iscoroutinefunction a deprecated alias of inspect.iscoroutinefunction and remove asyncio.coroutines._is_coroutine #94912
Closed
@martydill martydill mentioned this pull request Dec 16, 2022
Importing pook fails on Python 3.11 h2non/pook#84
Closed
@Abacn Abacn mentioned this pull request Apr 7, 2023
[Failing Test]: :sdks:java:container:pullLicenses faling since Apr 5th affecting lots of PostCommits apache/beam#26173
Closed
15 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Mar 30, 2026
feat(container): add registry auto-configuration from entry points [OMN-7065] OmniNode-ai/omnibase_core#756
Merged
3 of 4 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Apr 23, 2026
dev → main: workflow engine decomposition, search fixes, and test hardening nickth3man/a2a_research#17
Merged
13 tasks done
@coderabbitai coderabbitai Bot mentioned this pull request Jun 15, 2026
Update from task b7d23892-ef30-4aab-963d-77e1c4f603d2 bakhtawarfashion/bakhtawarfashion#2
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@graingert graingert graingert approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@aeros aeros Awaiting requested review from aeros

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@illia-v @graingert @vstinner @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.