GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43693: Add _PyCode_New(). by ericsnowcurrently · Pull Request #26375 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 26, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is an internal-only API that helps us manage the many values used to create a code object.

https://bugs.python.org/issue43693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
ericsnowcurrently requested a review from markshannon May 26, 2021 00:58
@ericsnowcurrently
ericsnowcurrently requested a review from tiran as a code owner May 26, 2021 00:58
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 26, 2021
@bedevere-bot bedevere-bot added the awaiting core review label May 26, 2021
@ericsnowcurrently
ericsnowcurrently removed the request for review from tiran May 26, 2021 01:01
@ericsnowcurrently ericsnowcurrently added the skip news label May 26, 2021
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 26, 2021
bpo-43693: Add _PyCode_New() and do some related cleanup. #26258
Closed
@ericsnowcurrently
ericsnowcurrently force-pushed the code-object-cleanup-new branch 2 times, most recently from 2cd8dfb to 9bcbbea Compare May 26, 2021 17:21
ericsnowcurrently added 6 commits May 26, 2021 13:24
@ericsnowcurrently
Add _PyCode_New().
974cb91
@ericsnowcurrently
Check nplainlocals instead of totalargs.
e4387e4
@ericsnowcurrently
Add _PyCode_Validate().
7e3a247
@ericsnowcurrently
Drop nlocals from marshaled code objects.
c310d7c
@ericsnowcurrently
Fix test_ctypes.
fa5d83e
@ericsnowcurrently
Stop using statics in PyCode_NewEmpty().
e356588
@ericsnowcurrently
ericsnowcurrently force-pushed the code-object-cleanup-new branch from a466357 to e356588 Compare May 26, 2021 19:25
This was referenced May 26, 2021
bpo-43693: Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. #26388
Merged
Handle boxing of cell variables in the bytecode. faster-cpython/ideas#41
Closed
markshannon
markshannon reviewed May 27, 2021
View reviewed changes
Comment thread Objects/codeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon reviewed May 27, 2021
View reviewed changes
Comment thread Objects/codeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented May 27, 2021

Copy link
Copy Markdown
Member

Just a couple of minor issues.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added 2 commits May 27, 2021 08:38
@ericsnowcurrently
Drop "inline" from a big function.
f2b227a
@ericsnowcurrently
Fail if there was an error.
b36ca68
@markshannon

markshannon commented May 27, 2021

Copy link
Copy Markdown
Member

LGTM 👍
bl-ue reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently removed the awaiting core review label May 27, 2021
@ericsnowcurrently
ericsnowcurrently merged commit 9f494d4 into python:main May 27, 2021
@ericsnowcurrently
ericsnowcurrently deleted the code-object-cleanup-new branch May 27, 2021 15:54
@markshannon markshannon mentioned this pull request May 28, 2021
bpo-43588: fix codeobject.c static variables under building under building Python with --with-experimental-isolated-subinterpreters may cause crash. #24968
Closed
@markshannon markshannon mentioned this pull request May 2, 2022
Logically merge cell and locals array. They are already contiguous in memory #87859
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @markshannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.