GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-38693: importlib.metadata f-strings (GH-26383) by miss-islington · Pull Request #26386 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 26, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit e6c815d)

Co-authored-by: Jason R. Coombs [email protected]

https://bugs.python.org/issue38693

Automerge-Triggered-By: GH:ericvsmith

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco @miss-islington
bpo-38693: importlib.metadata f-strings (pythonGH-26383)
43d824b 
Automerge-Triggered-By: GH:jaraco
(cherry picked from commit e6c815d)

Co-authored-by: Jason R. Coombs <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 26, 2021
@miss-islington

miss-islington commented May 26, 2021

Copy link
Copy Markdown
Contributor Author

@jaraco: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request May 26, 2021
bpo-38693: importlib.metadata f-strings #26383
Merged
@miss-islington

miss-islington commented May 26, 2021

Copy link
Copy Markdown
Contributor Author

@jaraco: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label May 26, 2021
ericvsmith
ericvsmith approved these changes May 26, 2021
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 26, 2021
@ericvsmith ericvsmith added the 🤖 automerge label May 26, 2021
@miss-islington

miss-islington commented May 26, 2021

Copy link
Copy Markdown
Contributor Author

@jaraco: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 78a8428 into python:3.10 May 26, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2021
@miss-islington
miss-islington deleted the backport-e6c815d-3.10 branch May 26, 2021 19:11
@gpshead gpshead mentioned this pull request May 21, 2022
Use f-strings instead of str.format within importlib #82874
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @ericvsmith @the-knights-who-say-ni @bedevere-bot @jaraco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.