GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44270: shutil.which: windows path/cmd searches pathext by scivision · Pull Request #26458 · python/cpython

Conversation

@scivision

@scivision scivision commented May 31, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

previously, the early short-circuit logic for shutil.which(cmd) where cmd includes a directory
component incorrectly gave None on Windows if the correct filename suffix was not also given.

For example, on Windows shutil.which("./foo") would not
find existing executable file ./foo.exe. Now it does.

https://bugs.python.org/issue44270

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@scivision
shutil.which: windows path/cmd searches pathext
3d04a7f 
previously, the early short-circuit when cmd includes a directory
component incorrectly gave None on Windows if the correct filename
suffix was not also given.
For example, on Windows `shutil.which("c:\Python\python") would not
find the file c:\Python\python.exe. Now it does.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label May 31, 2021
@the-knights-who-say-ni

the-knights-who-say-ni commented May 31, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@scivision

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label May 31, 2021
@github-actions

github-actions Bot commented Jul 1, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 1, 2021
@hugovk hugovk mentioned this pull request Feb 17, 2022
Cron job to close stale PRs python/core-workflow#93
Closed
@github-actions

github-actions Bot commented Feb 19, 2022

Copy link
Copy Markdown

Closing this stale PR because the CLA is still not signed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@scivision @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.