GeezerVison is showing github.com — [3.10] bpo-42972: Track sqlite3 statement objects (GH-26475) by erlend-aasland · Pull Request #26515 · python/cpython
Conversation
erlend-aasland
commented
Jun 3, 2021
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Allocate and track statement objects in pysqlite_statement_create.
By allocating and tracking creation of statement object in
pysqlite_statement_create(), the caller does not need to worry about GC
syncronization, and eliminates the possibility of getting a badly
created object. All related fault handling is moved to
pysqlite_statement_create().
Co-authored-by: Victor Stinner [email protected].
(cherry picked from commit fffa0f9)
Co-authored-by: Erlend Egeberg Aasland [email protected]
https://bugs.python.org/issue42972
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Allocate and track statement objects in pysqlite_statement_create.
By allocating and tracking creation of statement object in
pysqlite_statement_create(), the caller does not need to worry about GC
syncronization, and eliminates the possibility of getting a badly
created object. All related fault handling is moved to
pysqlite_statement_create().
Co-authored-by: Victor Stinner <[email protected]>.
(cherry picked from commit fffa0f9)
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
Build fails on Windows:
Error: D:\a\cpython\cpython\Modules\_sqlite\statement.c(117,27): error C2198: '_pysqlite_seterror': too few arguments for call [D:\a\cpython\cpython\PCbuild\_sqlite3.vcxproj]
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Backport from main branch.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
|
I couldn't merge this PR until the CI passed. And I didn't want to use automerge to be able to edit the commit message (to remove the second commit). The commit message of the second commit is ignored if you use git commit --fixup.
|
erlend-aasland reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
vstinner
vstinner approved these changes
berkerpeksag
Awaiting requested review from berkerpeksag
berkerpeksag is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vstinner
left a comment