GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42213: Remove redundant cyclic GC hack in sqlite3 by erlend-aasland · Pull Request #26517 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 3, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The sqlite3 module now fully implements the GC protocol, so there's no
need for this workaround anymore.

  • Add and use managed resource helper for connections using TESTFN
  • Sort test imports
  • Split open-tests into their own test case

https://bugs.python.org/issue42213

Automerge-Triggered-By: GH:vstinner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-42213: Remove redundant cyclic GC hack in sqlite3
a5a07bf 
The sqlite3 module now fully implements the GC protocol, so there's no
need for this workaround anymore.

- Add and use managed resource helper for connections with fs io
- Sort test imports
- Split open-tests into their own test case
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner June 3, 2021 16:07
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 3, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jun 3, 2021
@erlend-aasland erlend-aasland added the skip news label Jun 3, 2021
@erlend-aasland

erlend-aasland commented Jun 3, 2021

Copy link
Copy Markdown
Contributor Author

Ref. #26462 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Jun 3, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 3, 2021
@vstinner vstinner added the 🤖 automerge label Jun 3, 2021
@vstinner

vstinner commented Jun 3, 2021

Copy link
Copy Markdown
Member

@erlend-aasland: Don't touch anything, try the automerge label: it should merge the PR as soon as the CI pass.
erlend-aasland reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit d88b47b into python:main Jun 3, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 3, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-remove-gc-cache-hack branch June 3, 2021 19:14
@erlend-aasland erlend-aasland mentioned this pull request Jun 14, 2021
bpo-27334: roll back transaction if sqlite3 context manager fails to commit #26202
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @vstinner @miss-islington @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.