GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44315: Remove unused connection argument from pysqlite_step() by erlend-aasland · Pull Request #26535 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 4, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue44315

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-44315: Remove unused connection argument from pysqlite_step()
9f3d460
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner June 4, 2021 20:16
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 4, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jun 4, 2021
@erlend-aasland erlend-aasland added the skip news label Jun 4, 2021
@erlend-aasland

erlend-aasland commented Jun 4, 2021

Copy link
Copy Markdown
Contributor Author

This is an internal change; no news required.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland requested a review from pablogsal June 4, 2021 20:18
@pablogsal

pablogsal commented Jun 4, 2021

Copy link
Copy Markdown
Member

Why we weren't getting compiler warnings for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jun 4, 2021

Copy link
Copy Markdown
Contributor Author

Why we weren't getting compiler warnings for this?

Good question. The thought has crossed my mind too. There are definitely other compiler warnings in sqlite3 (for example unused function return values).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 7459208 into python:main Jun 4, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Jun 4, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-remove-unused-step-argument branch June 4, 2021 20:42
@erlend-aasland erlend-aasland mentioned this pull request Jul 30, 2021
[3.10] bpo-31746: Prevent segfaults when sqlite3.Connection is uninitialised (GH-27431) #27472
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.