GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38323: Remove test_cancel_make_subprocess_transport_exec as it has a rance condicion by pablogsal · Pull Request #26541 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 4, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

…

https://bugs.python.org/issue38323

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
bpo-38323: Remove test_cancel_make_subprocess_transport_exec as it ha…
24b235f 
…s a rance condicion
@pablogsal
pablogsal requested review from asvetlov and vstinner June 4, 2021 22:32
@pablogsal
pablogsal requested a review from 1st1 as a code owner June 4, 2021 22:32
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 4, 2021
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 4, 2021
@pablogsal pablogsal added skip news needs backport to 3.9 and removed tests Tests in the Lib/test dir labels Jun 4, 2021
@pablogsal pablogsal changed the title bpo-38323: Remove test_cancel_make_subprocess_transport_exec as it ha… bpo-38323: Remove test_cancel_make_subprocess_transport_exec as it has a rance condicion Jun 4, 2021
@pablogsal

pablogsal commented Jun 4, 2021

Copy link
Copy Markdown
Member Author

Turns out this is not enough:

./python -u -m test test_asyncio -m SubprocessMultiLoopWatcherTests -F --timeout=10.0 -j20
...
  File "/home/pablogsal/github/cpython/Lib/unittest/case.py", line 592 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/case.py", line 652 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/test/support/testresult.py", line 169 in run
  File "/home/pablogsal/github/cpython/Lib/test/support/__init__.py", line 960 in _run_suite
  File "/home/pablogsal/github/cpython/Lib/test/support/__init__.py", line 1083 in run_unittest
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 210 in _test_module
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 246 in _runtest_inner2
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 282 in _runtest_inner
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 154 in _runtest
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 194 in runtest
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest_mp.py", line 81 in run_tests_worker
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/main.py", line 661 in _main
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/main.py", line 641 in main
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/main.py", line 719 in main
  File "/home/pablogsal/github/cpython/Lib/test/regrtest.py", line 43 in _main
  File "/home/pablogsal/github/cpython/Lib/test/regrtest.py", line 47 in <module>
  File "/home/pablogsal/github/cpython/Lib/runpy.py", line 86 in _run_code
  File "/home/pablogsal/github/cpython/Lib/runpy.py", line 196 in _run_module_as_main
Kill <TestWorkerProcess #1 running test=test_asyncio pid=30022 time=950 ms> process group
Kill <TestWorkerProcess #2 running test=test_asyncio pid=30093 time=679 ms> process group
Kill <TestWorkerProcess #3 running test=test_asyncio pid=29847 time=1.6 sec> process group
Kill <TestWorkerProcess #4 running test=test_asyncio pid=29757 time=1.9 sec> process group
Kill <TestWorkerProcess #5 running test=test_asyncio pid=29922 time=1.3 sec> process group
Kill <TestWorkerProcess #6 running test=test_asyncio pid=29859 time=1.5 sec> process group
Kill <TestWorkerProcess #7 running test=test_asyncio pid=30146 time=362 ms> process group
Kill <TestWorkerProcess #8 running test=test_asyncio pid=29880 time=1.4 sec> process group
Kill <TestWorkerProcess #9 running test=test_asyncio pid=30028 time=934 ms> process group
Kill <TestWorkerProcess #10 running test=test_asyncio pid=29968 time=1.2 sec> process group
Kill <TestWorkerProcess #11 running test=test_asyncio pid=30000 time=1.0 sec> process group
Kill <TestWorkerProcess #12 running test=test_asyncio pid=29765 time=1.9 sec> process group
Kill <TestWorkerProcess #13 running test=test_asyncio pid=30183 time=112 ms> process group
Kill <TestWorkerProcess #14 running test=test_asyncio pid=30161 time=234 ms> process group
Kill <TestWorkerProcess #15 running test=test_asyncio pid=29888 time=1.4 sec> process group
Kill <TestWorkerProcess #16 running test=test_asyncio pid=29743 time=2.0 sec> process group
Kill <TestWorkerProcess #18 running test=test_asyncio pid=30101 time=548 ms> process group
Kill <TestWorkerProcess #19 running test=test_asyncio pid=29885 time=1.4 sec> process group
Kill <TestWorkerProcess #20 running test=test_asyncio pid=29762 time=1.9 sec> process group

== Tests result: FAILURE ==

565 tests OK.

1 test failed:
    test_asyncio

Total duration: 1 min 1 sec
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal mentioned this pull request Jun 4, 2021
bpo-38323, asyncio: Fix MultiLoopChildWatcher race condition #26536
Closed
@pablogsal pablogsal closed this Jun 4, 2021
@cjerdonek

cjerdonek commented Jun 4, 2021

Copy link
Copy Markdown
Member

Also, @pablogsal, you don't want to remove the methods because that removes the test for every subclass. You just want to skip the concrete SubprocessMultiLoopWatcherTests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Apr 10, 2022
asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x) #82504
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @cjerdonek @5jabb @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.