GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — bpo-38323: Change MultiLoopChildWatcher to install handlers for all the event loops by shreyanavigyan · Pull Request #26574 · python/cpython Conversation
|
|
Please remove the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ok |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm not sure that this issue solves MultiLoopChildWatcher design issue. The MultiLoopChildWatcher doc says that it can be used even if no event loop runs in the main thread, whereas add_signal_handler() must be called from the main thread: https://docs.python.org/dev/library/asyncio-eventloop.html#asyncio.loop.add_signal_handler |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
This PR changes MultiLoopChildWatcher in a way that it still doesn't require a running loop in the main thread. So the basic idea remains the same. The only change is that MultiLoopChildWatcher now can't be used from any other thread. I've tested it in the REPL and also the test ran for about 30 minutes, so I guess this patch works? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Breaking backwards compatibility is not an option for 3.9. I'd say the same for 3.10, since we're past feature freeze; beta phase is all about fixing regressions (and potentially ripping out newly introduced features). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
For 3.9, I agree. But since this is a bug wouldn't it be better to fix it in 3.10 beta? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
IMO, it's better to deprecate the class in 3.10 and remove it in 3.12, and for 3.9 do nothing. But, like Victor, I'm not an asyncio user, nor do I have any knowledge of that module, so my opinion does not really matter here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.