GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44412: add `os.path.fileuri()` function. by barneygale · Pull Request #26708 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jun 13, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

One of only three pieces of functionality that's available in the
object-oriented pathlib library, but not the traditional os/os.path
modules.

By moving this functionality to low-level modules, we make progress towards
being able to remove pathlib._Flavour in bpo-44136 and ultimately unlock
pathlib's OOPy potential in bpo-24132.

This commit also adjusts urllib.request.pathname2url() to use the new
implementation on Windows. On other platforms, the existing implementation
is retained due to its simplicity and its highly questionable support for
relative file URIs (like 'file:photos/foo.txt')

https://bugs.python.org/issue44412

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@barneygale
bpo-44412: add os.path.fileuri() function.
fbf5e14
One of only three pieces of functionality that's available in the
object-oriented pathlib library, but not the traditional os/os.path
modules.

By moving this functionality to low-level modules, we make progress towards
being able to remove `pathlib._Flavour` in bpo-44136 and ultimately unlock
pathlib's OOPy potential in bpo-24132.

This commit also adjusts `urllib.request.pathname2url()` to use the new
implementation on Windows. On other platforms, the existing implementation
is retained due to its simplicity and its highly questionable support for
relative file URIs (like `'file:photos/foo.txt'`)
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 13, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jun 13, 2021
@barneygale
barneygale marked this pull request as draft June 13, 2021 18:26
@github-actions

github-actions Bot commented Jul 14, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 14, 2021
@barneygale barneygale closed this Jan 1, 2022
@barneygale barneygale mannequin mentioned this pull request Jun 21, 2022
Remove pathlib flavours #88302
Closed
@projetmbc projetmbc mannequin mentioned this pull request Jun 21, 2022
Direct sub-classing of pathlib.Path #68320
Closed
@barneygale barneygale mannequin mentioned this pull request Apr 10, 2022
Add os.path.fileuri() function #88578
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil Awaiting requested review from orsenthil orsenthil will be requested when the pull request is marked ready for review orsenthil is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@barneygale @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.