GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44431: Added command line functionality to UUID module. by ephenix · Pull Request #26751 · python/cpython

Conversation

@ephenix

@ephenix ephenix commented Jun 16, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

I often need to generate a GUID quickly and from the command line.

Rather than install additional utilities to accomplish this on various platforms, it would be amazing if Python had this functionality built-in.

I specifically avoided using any additional modules such as argparse to handle the few arguments that uuid3 and uuid5 have to keep the functionality lightweight, instead relying on sys.argv to capture the additional arguments from the CLI.

Looking forward to hearing others' thoughts on this functionality.

https://bugs.python.org/issue44431

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Eric Phenix
Added command line functionality to UUID module.
c8432c3
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jun 16, 2021
@the-knights-who-say-ni

the-knights-who-say-ni commented Jun 16, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@ephenix

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Jun 16, 2021
nanjekyejoannah
nanjekyejoannah reviewed Jun 16, 2021
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing tests and add a news entry given this is an enhancement.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jun 17, 2021
ephenixaws added 2 commits June 16, 2021 23:58
@ephenixaws
Added whitespace and blurb entry.
fe7fea1
@ephenixaws
implemented -h --help which prints module doc string. Added command-l…
d00cf6b 
…ine usage to doc string.
nanjekyejoannah
nanjekyejoannah reviewed Jun 17, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2021-06-16-23-57-45.bpo-44431.nA8C9m.rst
@@ -0,0 +1 @@
UUID module now supports being called from command line. ex > python -m uuid

@nanjekyejoannah nanjekyejoannah Jun 17, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need an example in a news entry. I would do way with ex > python -m uuid .

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/uuid.py

if __name__ == '__main__':
"""
Enables uuid to be called from the command line

@nanjekyejoannah nanjekyejoannah Jun 17, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can move this logic into a helper method so that we just call the method here? Most libraries seem to follow this e.g Lib/timeit.py

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Jul 18, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 18, 2021
@ephenix ephenix mannequin mentioned this pull request Nov 7, 2022
Add command-line functionality to uuid module #88597
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ephenix @the-knights-who-say-ni @nanjekyejoannah @bedevere-bot @ephenixaws
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.