GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38291: Reset DeprecationWarning filters in test_typing io and re by Fidget-Spinner · Pull Request #26811 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jun 20, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue38291

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Fidget-Spinner
Reset DeprecationWarning filters in test_typing io and re
5190297
@Fidget-Spinner
Fidget-Spinner requested review from gvanrossum and ilevkivskyi as code owners June 20, 2021 17:27
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 20, 2021
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jun 20, 2021
@Fidget-Spinner
Fidget-Spinner marked this pull request as draft June 20, 2021 17:27
@Fidget-Spinner Fidget-Spinner changed the title Reset DeprecationWarning filters in test_typing io and re bpo-38291: Reset DeprecationWarning filters in test_typing io and re Jun 20, 2021
@Fidget-Spinner Fidget-Spinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 20, 2021
@bedevere-bot

bedevere-bot commented Jun 20, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 5190297 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 20, 2021
gvanrossum
gvanrossum approved these changes Jun 21, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we went too quick here? I’m not sure what this does (it’s been a long time since I played with warnings) but if this is blocking other PRs I am happy to merge it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 21, 2021
@Fidget-Spinner
Fidget-Spinner marked this pull request as ready for review June 21, 2021 10:02
@Fidget-Spinner

Fidget-Spinner commented Jun 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I suppose we went too quick here? I’m not sure what this does (it’s been a long time since I played with warnings) but if this is blocking other PRs I am happy to merge it.

Luckily this isn't blocking other PRs, buildbot failures only block releases AFAIK. As Sebastian mentioned on the bpo issue, it's an Azure pipelines problem. The specific pipeline is only run after a commit is made. Even with the test-with-buildbots label, I'm unable to recreate the conditions for the failure on a PR. At best, this fix is a hunch which I have no way of verifying or reproducing locally.

This fix wasn't clear to me too, until I read this part of the warnings docs:
https://docs.python.org/3/library/warnings.html#testing-warnings

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum
gvanrossum merged commit c5d700f into python:main Jun 21, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 21, 2021
@bedevere-bot

bedevere-bot commented Jun 21, 2021

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner
Fidget-Spinner deleted the fix-azure-appx branch June 22, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Fidget-Spinner @bedevere-bot @gvanrossum @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.