GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38291: Fix a spurious warning when using help(object) by srittau · Pull Request #27039 · python/cpython

Conversation

@srittau

@srittau srittau commented Jul 5, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue38291

Automerge-Triggered-By: GH:gvanrossum

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srittau
Fix a spurious warning when using help(object)
8900c2d 
help(object) via pydoc.TextDoc.docclass(object) iterates over the
subclasses of object, which includes typing.io and typing.re if typing
is imported. It tries to access cls.__module__ for each of those
sub-classes. This change suppresses warnings when accessing
cls.__module__.
@srittau
srittau requested review from gvanrossum and ilevkivskyi as code owners July 5, 2021 17:49
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 5, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jul 5, 2021
@srittau

srittau commented Jul 5, 2021

Copy link
Copy Markdown
Contributor Author

This should not need a NEWS entry per:

These are the two exceptions:

  1. [...]
  2. If a change is a fix (or other adjustment) to an earlier unreleased change and the original NEWS entry remains valid, then no additional entry is needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srittau

srittau commented Jul 5, 2021

Copy link
Copy Markdown
Contributor Author

The Azure build failure seems unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum reviewed Jul 6, 2021
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum added the skip news label Jul 6, 2021
@srittau
Use tuple
b18dd18
gvanrossum
gvanrossum approved these changes Jul 6, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 6, 2021
@gvanrossum gvanrossum added the 🤖 automerge label Jul 6, 2021
@miss-islington

miss-islington commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

@srittau: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srittau

srittau commented Jul 6, 2021

Copy link
Copy Markdown
Contributor Author

This time, Azure passes, but the address sanitizer(?) test times out. Looks like an unrelated multiprocessing error, possibly a race condition.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Jul 6, 2021

Copy link
Copy Markdown
Member

Alas, we have to close and reopen the PR to make the last test pass (hopefully), GitHub won't let me merge without that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum closed this Jul 6, 2021
@gvanrossum gvanrossum reopened this Jul 6, 2021
@miss-islington

miss-islington commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

@srittau: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
2 similar comments
@miss-islington

miss-islington commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

@srittau: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

@srittau: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum merged commit 8b849ea into python:main Jul 6, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 6, 2021
@bedevere-bot

bedevere-bot commented Jul 6, 2021

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Jul 6, 2021

Copy link
Copy Markdown
Member

Is a backport needed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srittau
srittau deleted the typing-io branch July 6, 2021 15:27
@srittau

srittau commented Jul 6, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Thanks and no backport needed, the original change is just in the 3.11 branch trunk.
gvanrossum reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@srittau @miss-islington @gvanrossum @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.