GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43950: distinguish errors happening on character offset decoding by isidentical · Pull Request #27217 · python/cpython

Conversation

@isidentical

@isidentical isidentical commented Jul 17, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

_PyPegen_byte_offset_to_character_offset now returns -1 on error since we need to distinguish 0-width lines from errors. Also the error checks are added to the call sites.

https://bugs.python.org/issue43950

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@isidentical
bpo-43950: distinguish errors happening on character offset decoding
649f51d
@isidentical
isidentical requested review from ammaraskar and pablogsal July 17, 2021 16:31
@isidentical
isidentical requested a review from lysnikolaou as a code owner July 17, 2021 16:32
@bedevere-bot bedevere-bot added the awaiting core review label Jul 17, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 17, 2021
@isidentical isidentical added the skip news label Jul 17, 2021
pablogsal
pablogsal approved these changes Jul 20, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 20, 2021
@pablogsal
pablogsal merged commit fbc349f into python:main Jul 20, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 20, 2021
@isidentical

isidentical commented Jul 20, 2021

Copy link
Copy Markdown
Member Author

Thanks @pablogsal!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal mentioned this pull request Apr 13, 2022
Include column offsets for bytecode instructions #88116
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@ammaraskar ammaraskar Awaiting requested review from ammaraskar
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@isidentical @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.