GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-88843: Do not allow to parse line breaks between quotes in sniffer regexes. by ptokarski · Pull Request #27256 · python/cpython

Conversation

@ptokarski

@ptokarski ptokarski commented Jul 20, 2021 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

bpo-44677: Do not allow to parse line breaks between quotes in CSV sniffer regexes

  • Issue: CSV sniffing falsely detects space as a delimiter #88843

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dparker2 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@piotr-profound
Do not allow to parse line breaks between quotes in sniffer regexes.
cbc6c14
@bedevere-bot bedevere-bot added the awaiting review label Jul 20, 2021
@the-knights-who-say-ni

This comment was marked as outdated.

Sign in to view
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jul 20, 2021
@github-actions

github-actions Bot commented Aug 20, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 20, 2021
@the-knights-who-say-ni the-knights-who-say-ni added CLA not signed and removed CLA not signed labels Oct 5, 2021
@the-knights-who-say-ni the-knights-who-say-ni added CLA not signed and removed CLA not signed labels Nov 11, 2021
@CoolCat467

CoolCat467 commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

ptokarski has signed CLA, but piotr-profound has not.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added CLA not signed and removed CLA not signed labels Feb 1, 2022
@hugovk hugovk mentioned this pull request Feb 17, 2022
Cron job to close stale PRs python/core-workflow#93
Closed
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@hugovk

This comment was marked as resolved.

Sign in to view
@the-knights-who-say-ni the-knights-who-say-ni added CLA not signed and removed CLA not signed labels Feb 21, 2022
@the-knights-who-say-ni the-knights-who-say-ni added CLA not signed and removed CLA not signed labels Mar 18, 2022
@ambv ambv closed this Apr 10, 2022
@ambv ambv reopened this Apr 10, 2022
@ambv ambv removed the CLA not signed label Apr 10, 2022
@ptokarski ptokarski mannequin mentioned this pull request Apr 10, 2022
CSV sniffing falsely detects space as a delimiter #88843
Open
@github-actions

github-actions Bot commented Aug 11, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 11, 2022
@StanFromIreland StanFromIreland changed the title Do not allow to parse line breaks between quotes in sniffer regexes. gh-88843: Do not allow to parse line breaks between quotes in sniffer regexes. Oct 3, 2025
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Apr 9, 2026
@github-actions

github-actions Bot commented May 10, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 10, 2026
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 14, 2026
gh-83273: Rewrite csv.Sniffer dialect detection using trial parsing #153694
Merged
@serhiy-storchaka

serhiy-storchaka commented Jul 21, 2026

Copy link
Copy Markdown
Member

Thank you for the patch, and sorry for the long delay.

On the main branch the sniffer was rewritten (gh-83273), so these regular expressions no longer exist there and the sample from the issue is detected correctly now.

For the maintenance branches this change is too risky: a quoted field may legitimately contain a line break, and forbidding that in the pattern loses the evidence for the real delimiter. On 4000 generated samples it changes the guess for 1.4% of them, and in all of those cases the new guess is worse — for example '"multi\nline"\tit\'s\nit\'s\t"multi\nline"\n' is detected as '\t' before the change and as 'l' after it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ptokarski @the-knights-who-say-ni @CoolCat467 @hugovk @serhiy-storchaka @ambv @bedevere-bot @piotr-profound
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.