GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41255: handle argparse errors with exit_on_error=False consistently by joshmeranda · Pull Request #27295 · python/cpython

Conversation

@joshmeranda

@joshmeranda joshmeranda commented Jul 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

bpo-41255

When unknown arguments are passed to parse_args or required arguments not passed to either parse_args or parse_known_args argpase exits despite exit_on_error=False. This is not very intuitive, instead any error parsing arguments should result in an ArgumentError which can be handled by the user.

https://bugs.python.org/issue41255

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zozoens31 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joshmeranda
bpo-41255: unify hanling of exit_on_error
45ac2a7
@bedevere-bot bedevere-bot added the awaiting review label Jul 22, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jul 22, 2021
@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 22, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@joshmeranda

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
blurb-it Bot and others added 2 commits July 22, 2021 21:56
@blurb-it
📜🤖 Added by blurb_it.
c846f72
@joshmeranda
bpo-41255: resolve suspicious reST construct in modified docs
bca0bf5
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jul 27, 2021
@github-actions

github-actions Bot commented Aug 27, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 27, 2021
@jacobtylerwalls jacobtylerwalls mentioned this pull request Feb 5, 2022
gh-85427: Prevent exits if ArgumentParser.exit_on_error is False #30832
Closed
MaxwellDupre
MaxwellDupre approved these changes Mar 14, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me:
Ran 1658 tests in 2.516s
OK

Simple bug mentioned case too!
Nice work

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Mar 14, 2022
@joshmeranda
Merge branch 'main' into issue-41255
2655026
@matthewhughes934 matthewhughes934 mannequin mentioned this pull request Apr 10, 2022
Argparse.parse_args exits on unrecognized option with exit_on_error=False #85427
Closed
@AA-Turner AA-Turner closed this Jun 7, 2022
@AA-Turner AA-Turner reopened this Jun 7, 2022
@AA-Turner

AA-Turner commented Jun 7, 2022

Copy link
Copy Markdown
Member

Trigger CLA.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner added type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory and removed CLA signed stale Stale PR or inactive for long period of time. labels Jun 7, 2022
@github-actions

github-actions Bot commented Aug 11, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 11, 2022
@serhiy-storchaka

serhiy-storchaka commented Jun 28, 2024

Copy link
Copy Markdown
Member

Thank you for your contribution @joshmeranda. I apologize for the fact that this PR was neglected for a long time. The problem has already been solved in another way.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time. stdlib Standard Library Python modules in the Lib/ directory type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@joshmeranda @the-knights-who-say-ni @AA-Turner @serhiy-storchaka @MaxwellDupre @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.