GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updating a code example in the docs - classes.rst by sameh-farouk · Pull Request #27341 · python/cpython

Conversation

@sameh-farouk

@sameh-farouk sameh-farouk commented Jul 24, 2021

Copy link
Copy Markdown

the giving example for the generator expressions that yield all words from a page will actually yield all the characters from that page instead, giving that the page holds a multiline string as the name implies.

>>> page = """hello, world
... I love Python!"""
>>> set(word for line in page for word in line.split())
{'n', 'h', 'd', 'o', 'e', ',', 'r', 'I', 't', 'v', 'P', 'l', 'w', 'y', '!'}

the example could be correct only if the page variable contains a list for lines instead, but then the variable name would need to reconsider, for example, lines.

the correct code would be something like:

>>> set(word for line in page.splitlines() for word in line.split())
{'love', 'world', 'I', 'hello,', 'Python!'}

the same generator expressions also could be simplified to just

>>> set(word for word in page.split())
{'love', 'world', 'I', 'hello,', 'Python!'}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sameh-farouk
Update classes.rst
1e1d126 
the giving example for the generator expressions that yield all words from a page will actually yield all the characters from that page instead, giving that the `page` holds a multiline string.
the example could be correct only if the `page` variable contains a list for lines instead, but then the variable name would need to reconsider, ex: `lines`.

also the same generator expressions could be simplified to just `unique_words = set(word for word in page.split())`
@bedevere-bot bedevere-bot added the awaiting review label Jul 24, 2021
@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 24, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@sameh-farouk

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jul 24, 2021
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 24, 2021
domdfcoding
domdfcoding reviewed Jul 27, 2021
View reviewed changes
Comment thread Doc/tutorial/classes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sameh-farouk @domdfcoding
Removing leading space
336e4c6 
Co-authored-by: Dominic Davis-Foster <[email protected]>
@github-actions

github-actions Bot commented Aug 28, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2021
@hugovk hugovk mentioned this pull request Feb 17, 2022
Cron job to close stale PRs python/core-workflow#93
Closed
@github-actions

github-actions Bot commented Feb 19, 2022

Copy link
Copy Markdown

Closing this stale PR because the CLA is still not signed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@domdfcoding domdfcoding domdfcoding left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sameh-farouk @the-knights-who-say-ni @domdfcoding @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.