GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11 by corona10 · Pull Request #27837 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Aug 19, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue42255

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 requested review from ned-deily and ronaldoussoren August 19, 2021 14:51
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 19, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Aug 19, 2021
corona10
corona10 commented Aug 19, 2021
View reviewed changes
Comment thread Doc/library/webbrowser.rst Outdated

@corona10 corona10 Aug 19, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be backported

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ambv ambv Sep 3, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can reasonably call renaming MacOSX to MacOSXOSAScript a "backport" of this PR since it is about the deprecation. I'll of course accept PRs to 3.10 and 3.9 that make this doc change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
corona10
corona10 commented Aug 19, 2021
View reviewed changes
Comment thread Doc/library/webbrowser.rst Outdated

@corona10 corona10 Aug 19, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be backported

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 requested a review from ambv September 1, 2021 03:05
@corona10

corona10 commented Sep 1, 2021

Copy link
Copy Markdown
Member Author

@ambv Can you please take a look? cc @ned-deily @ronaldoussoren
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv
ambv requested changes Sep 2, 2021
View reviewed changes

@ambv ambv left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PEP 387 for our deprecation policy.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/webbrowser.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2021-08-19-23-49-10.bpo-42255.ofe3ms.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 2, 2021
@bedevere-bot

bedevere-bot commented Sep 2, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Sep 2, 2021
@ambv

ambv commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

@corona10, please also resolve the conflict with main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11
8f670b5
@corona10
corona10 force-pushed the bpo-42255 branch from a035970 to 8f670b5 Compare September 3, 2021 13:33
@corona10

corona10 commented Sep 3, 2021

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Sep 3, 2021
@bedevere-bot

bedevere-bot commented Sep 3, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from ambv September 3, 2021 13:34
@ambv

ambv commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

@corona10, your force-push undid the changes to 3.13. I'll make them myself since you had them in a035970b79921a66d29688b3a30e5108af3fa82c.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
s/3.12/3.13/
39b243b
@ambv
ambv merged commit bc1c49f into python:main Sep 3, 2021
@bedevere-bot bedevere-bot removed the awaiting change review label Sep 3, 2021
@corona10
corona10 deleted the bpo-42255 branch September 3, 2021 16:21
@corona10

corona10 commented Sep 3, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@ambv Thanks :)
I notice it now that I made mistake while rebased on my local environment :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronaldoussoren ronaldoussoren mentioned this pull request May 23, 2023
webbrowser.MacOSX is unused, untested and undocumented #86421
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren
@ned-deily ned-deily Awaiting requested review from ned-deily
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @bedevere-bot @ambv @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.