GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-24234: fix bytes.__bytes__ to not truncate at a zero byte by mdickinson · Pull Request #27902 · python/cpython

Conversation

@mdickinson

@mdickinson mdickinson commented Aug 23, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes buildbot failures introduced in GH-27901.

https://bugs.python.org/issue24234

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdickinson
Fix bytes.__bytes__ to not truncate at a zero byte
72ea593
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 23, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Aug 23, 2021
@mdickinson mdickinson added skip news type-bug An unexpected behavior, bug, or error labels Aug 23, 2021
@mdickinson
mdickinson requested a review from corona10 August 23, 2021 10:35
@mdickinson mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 23, 2021
@bedevere-bot

bedevere-bot commented Aug 23, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 72ea593 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 23, 2021
corona10
corona10 approved these changes Aug 23, 2021
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdickinson Thank you for quick fix 👍
LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 23, 2021
@mdickinson

mdickinson commented Aug 23, 2021

Copy link
Copy Markdown
Member Author

The s390x buildbot is reporting:

test_typing leaked [1, 1, 1] memory blocks, sum=3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Aug 23, 2021

Copy link
Copy Markdown
Member

@mdickinson Other Refleak tests doesn't report the issue :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdickinson

mdickinson commented Aug 23, 2021

Copy link
Copy Markdown
Member Author

I'll merge anyway - this change is obviously needed. The Arch Linux buildbot failure looks unrelated, and has been happening for a while. We can keep an eye on the s390x buildbot for a while to see if the test_typing refleak is persistent.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdickinson
mdickinson merged commit ae52591 into python:main Aug 23, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 23, 2021
@mdickinson
mdickinson deleted the bpo-24234-fix-bytes-bytes branch August 23, 2021 14:24
@mdickinson

mdickinson commented Aug 26, 2021

Copy link
Copy Markdown
Member Author

The s390x buildbot is reporting [...]

There have been 9 runs of that buildbot since; none of them have reproduced that same test_typing leak, so I think we can be reasonably confident that it wasn't caused by this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mdickinson @bedevere-bot @corona10 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.