GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-27334: roll back transaction if sqlite3 context manager fails to commit (GH-26202) by erlend-aasland · Pull Request #27943 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 25, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Co-authored-by: Luca Citi
Co-authored-by: Berker Peksag [email protected].
(cherry picked from commit 7ecd342)

Co-authored-by: Erlend Egeberg Aasland [email protected]

https://bugs.python.org/issue27334

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner August 25, 2021 11:43
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 25, 2021
@bedevere-bot bedevere-bot mentioned this pull request Aug 25, 2021
bpo-27334: roll back transaction if sqlite3 context manager fails to commit #26202
Merged
@bedevere-bot bedevere-bot added the awaiting review label Aug 25, 2021
@erlend-aasland
erlend-aasland requested a review from pablogsal August 25, 2021 11:44
@erlend-aasland
erlend-aasland marked this pull request as draft August 25, 2021 11:57
Erlend Egeberg Aasland added 2 commits August 25, 2021 14:04
Erlend Egeberg Aasland
[3.10] bpo-27334: roll back transaction if sqlite3 context manager fa…
3978e28 
…ils to commit (pythonGH-26202)

Co-authored-by: Luca Citi
Co-authored-by: Berker Peksag <[email protected]>.
(cherry picked from commit 7ecd342)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Erlend E. Aasland
bpo-27334: Fix ref. leak
3468d6c
@erlend-aasland
erlend-aasland force-pushed the backport-7ecd342-3.10 branch from 439b1b0 to 3468d6c Compare August 25, 2021 12:05
@erlend-aasland
erlend-aasland marked this pull request as ready for review August 25, 2021 12:05
@erlend-aasland

erlend-aasland commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

FYI, asyncio failed on Azure Pipelines CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv

ambv commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

I restarted it, all good.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Aug 28, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 28, 2021
@pablogsal
pablogsal merged commit 2a80893 into python:3.10 Aug 28, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 28, 2021
@erlend-aasland
erlend-aasland deleted the backport-7ecd342-3.10 branch August 28, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @ambv @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.