GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — asyncio: don't do anything in _SelectorDatagramTransport if we're closed by istankovic · Pull Request #28110 · python/cpython

Conversation

@istankovic

@istankovic istankovic commented Sep 1, 2021

Copy link
Copy Markdown

It could happen that the transport's sendto() method is invoked after
the transport was closed. Closing the transport sets the _sock attribute
to None, which then causes the following exception:

Traceback (most recent call last):
  File "/usr/lib/python3.9/asyncio/selector_events.py", line 1056, in sendto
self._sock.sendto(data, addr)
AttributeError: 'NoneType' object has no attribute 'sendto'

So just check if we're closed before doing anything, similarly to what we already
do in other methods.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
netcriptus reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Ivan Stanković
asyncio: don't do anything in _SelectorDatagramTransport if we're closed
96b6e0e 
It could happen that the transport's sendto() method is invoked after
the transport was closed. Closing the transport sets the _sock attribute
to None, which then causes the following exception:

    Traceback (most recent call last):
      File "/usr/lib/python3.9/asyncio/selector_events.py", line 1056, in sendto
	self._sock.sendto(data, addr)
    AttributeError: 'NoneType' object has no attribute 'sendto'

So just check if we're closed before doing anything, similarly to what we already
do in other methods.
@istankovic
istankovic requested review from 1st1 and asvetlov as code owners September 1, 2021 12:58
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Sep 1, 2021
@the-knights-who-say-ni

the-knights-who-say-ni commented Sep 1, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@istankovic

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Sep 1, 2021
@github-actions

github-actions Bot commented Oct 2, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 2, 2021
@hugovk hugovk mentioned this pull request Feb 17, 2022
Cron job to close stale PRs python/core-workflow#93
Closed
@github-actions

github-actions Bot commented Feb 18, 2022

Copy link
Copy Markdown

Closing this stale PR because the CLA is still not signed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@istankovic @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.