GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45026: More compact range iterator (alt) by serhiy-storchaka · Pull Request #28176 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 5, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Keep the current and stop values instead of initial start, index and initial length.

https://bugs.python.org/issue45026

#89189

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
serhiy-storchaka added 7 commits August 27, 2021 06:03
@serhiy-storchaka
bpo-45026: More compact range iterator
2fa0b0d
@serhiy-storchaka
Fix sizeof test.
1cd0138
@serhiy-storchaka
Merge branch 'main' into range-iter
214f204
@serhiy-storchaka
Add explicit tests for __setstate__.
3133f66
@serhiy-storchaka
Add a NEWS entry.
7a42474
@serhiy-storchaka
Merge branch 'main' into range-iter
175b0d3
@serhiy-storchaka
Keep stop instead of len.
177da8c
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Sep 5, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 5, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Sep 5, 2021
ambv
ambv reviewed Sep 8, 2021
View reviewed changes
Comment thread Objects/rangeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 8, 2021
@bedevere-bot

bedevere-bot commented Sep 8, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 177da8c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 8, 2021
@ambv

ambv commented Sep 10, 2021

Copy link
Copy Markdown
Contributor

The refleak here looks real:

test_range leaked [7, 7, 7] references, sum=21
test_range leaked [5, 5, 5] memory blocks, sum=15
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added 2 commits September 10, 2021 19:18
@serhiy-storchaka
Merge branch 'main' into range-iter2
155cb3c
@serhiy-storchaka
Fix refleaks.
dced0e6
@serhiy-storchaka

serhiy-storchaka commented Sep 10, 2021

Copy link
Copy Markdown
Member Author

@ambv please do not merge until I run benchmarks.

ambv reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 10, 2021
@bedevere-bot

bedevere-bot commented Sep 10, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit dced0e6 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 10, 2021
@serhiy-storchaka
Merge branch 'main' into range-iter2
3219849
@serhiy-storchaka
serhiy-storchaka requested a review from ambv September 22, 2021 17:11
@serhiy-storchaka
Merge branch 'main' into range-iter2
cffa90a
@github-actions

github-actions Bot commented Oct 26, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 26, 2021
@serhiy-storchaka
Merge branch 'main' into range-iter2
dbdb0cc
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger May 3, 2022 09:01
@serhiy-storchaka

serhiy-storchaka commented May 3, 2022

Copy link
Copy Markdown
Member Author

See also #27986.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka serhiy-storchaka mentioned this pull request May 3, 2022
gh-89189: More compact range iterator #27986
Merged
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 12, 2022
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 18, 2022
More compact range iterator #89189
Closed
serhiy-storchaka added 3 commits November 27, 2022 10:34
@serhiy-storchaka
Merge branch 'main' into range-iter2
109445f
@serhiy-storchaka
Unify code with range-iter.
189ca23
@serhiy-storchaka
Microoptimize small range iteration.
d315911
@serhiy-storchaka serhiy-storchaka closed this Nov 30, 2022
@serhiy-storchaka
serhiy-storchaka deleted the range-iter2 branch July 1, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv Awaiting requested review from ambv
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @bedevere-bot @ambv @the-knights-who-say-ni @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.