GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44958: Fix ref. leak introduced in GH-27844 by erlend-aasland · Pull Request #28490 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Sep 21, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Modify managed_connect() helper to support in-memory databases. Use it
for the regression tests added in GH-27844.

https://bugs.python.org/issue44958

Automerge-Triggered-By: GH:pablogsal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland added 2 commits September 21, 2021 14:40
Erlend E. Aasland
bpo-44958: Fix ref. leak in test_table_lock_cursor_non_readonly_select()
7342276
Erlend E. Aasland
bpo-44958: Fix ref. leak in test_table_lock_cursor_non_readonly_select()
24e0e12 
Modify managed_connect() helper to support in-memory databases. Use it
for the regression tests added in pythonGH-27844.
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner September 21, 2021 12:52
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 21, 2021
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 21, 2021
@erlend-aasland
erlend-aasland requested a review from pablogsal September 21, 2021 12:53
@erlend-aasland erlend-aasland changed the title bpo-44958: Fix ref. leak in test_table_lock_cursor_non_readonly_select() bpo-44958: Fix ref. leak in test_table_lock_cursor_non_readonly_select Sep 21, 2021
@erlend-aasland erlend-aasland changed the title bpo-44958: Fix ref. leak in test_table_lock_cursor_non_readonly_select bpo-44958: Fix ref. leak introduced in GH-27844 Sep 21, 2021
@erlend-aasland erlend-aasland mentioned this pull request Sep 21, 2021
bpo-44958: Only reset sqlite3 statements when needed #27844
Merged
@erlend-aasland erlend-aasland added the skip news label Sep 21, 2021
pablogsal
pablogsal approved these changes Sep 21, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 21, 2021
@pablogsal pablogsal added the 🤖 automerge label Sep 21, 2021
@miss-islington

miss-islington commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 3e3ff09 into python:main Sep 21, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 21, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-fix-refleak branch September 21, 2021 13:37
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
[sqlite3] only reset statements when needed #89121
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.