GeezerVison is showing github.com — bpo-41710: Add _PyTime_AsTimespec_clamp() by vstinner · Pull Request #28629 · python/cpython
Conversation
vstinner
commented
Sep 29, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Add the _PyTime_AsTimespec_clamp() function: similar to
_PyTime_AsTimespec(), but clamp to _PyTime_t min/max and don't raise
an exception.
PyThread_acquire_lock_timed() now uses _PyTime_AsTimespec_clamp() to
remove the Py_UNREACHABLE() code path.
- Add _PyTime_AsTime_t() function.
- Add PY_TIME_T_MIN and PY_TIME_T_MAX constants.
- Replace _PyTime_AsTimeval_noraise() with _PyTime_AsTimeval_clamp().
- Add pytime_divide_round_up().
- Fix integer overflow in pytime_divide().
- Add pytime_divmod() function.
https://bugs.python.org/issue41710
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
changed the title
bpo-41710: Add _PyTime_AsTimespec_truncate()
bpo-41710: Add _PyTime_AsTimespec_clamp()
Sep 29, 2021
Add the _PyTime_AsTimespec_clamp() function: similar to
_PyTime_AsTimespec(), but clamp to _PyTime_t min/max and don't raise
an exception.
PyThread_acquire_lock_timed() now uses _PyTime_AsTimespec_clamp() to
remove the Py_UNREACHABLE() code path.
* Add _PyTime_AsTime_t() function.
* Add PY_TIME_T_MIN and PY_TIME_T_MAX constants.
* Replace _PyTime_AsTimeval_noraise() with _PyTime_AsTimeval_clamp().
* Add pytime_divide_round_up() function.
* Fix integer overflow in pytime_divide().
* Add pytime_divmod() function.
Reviewers
abalkin
Awaiting requested review from abalkin
pganssle
Awaiting requested review from pganssle
pganssle is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.