GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45116 Fix another performance regression on Windows by neonene · Pull Request #28630 · python/cpython

Conversation

@neonene

@neonene neonene commented Sep 29, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Currently, MSVC tends to share the same code blocks in a too big function.
In the ceval-loop, NEXTOPARG() or DISPATCH() macros are unexpectedly shared and joined with (long) jump instructions, which disturb PGO profiling.

With this PR, MSVC seems to generate expected codes for #25244.

https://bugs.python.org/issue45116

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@neonene
use only tracing_dispatch if not USE_COMPUTED_GOTOS
92e5fba
@neonene
neonene requested a review from markshannon as a code owner September 29, 2021 16:54
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 29, 2021
@bedevere-bot bedevere-bot added the awaiting review label Sep 29, 2021
@pablogsal

pablogsal commented Sep 29, 2021

Copy link
Copy Markdown
Member

I have not reviewed this but this PR should not be landed before #28488, otherwise is going to be a nightmare to validate that code path again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Sep 29, 2021

Copy link
Copy Markdown
Member

are unexpectedly shared and joined

But that is designed like that on pourpose, and has proven to improve performance in the past. This would need some validation because AFAIK it goes against previous work and knowledge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neonene neonene closed this Sep 30, 2021
@neonene
neonene deleted the bpo-45116-1 branch September 30, 2021 01:58
@neonene neonene mannequin mentioned this pull request Apr 10, 2022
Performance regression 3.10b1: inlining issue in the big _PyEval_EvalFrameDefault() function with Visual Studio (MSC) #89279
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@neonene @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.